android/nowinandroid

[Bug]: Significant amount of overdraw throughout the app

Open

#514 opened on Dec 29, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Kotlin (4,404 forks)batch import
bughelp wantedp1

Repository metrics

Stars
 (21,223 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Is there an existing issue for this?

  • I have searched the existing issues

Is there a StackOverflow question about this issue?

  • I have searched StackOverflow

What happened?

If you enable "Debug GPU overdraw" in the Developer options, you'll see most of the app is pink (3 levels of overdraw) or red (4+ levels of overdraw). A big chunk of this is coming from the backgrounds. For example, NiaBackground creates a Surface, then NiaGradientBackground creates another Surface and also potentially draws on top, then Scaffold creates another Surface (though it looks transparent), and then the content is drawn on top of that.

Relevant logcat output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributor guide

Research direction
Investigate the NiaBackground and NiaGradientBackground composables to reduce unnecessary Surface layers. Look at how the Scaffold's background interacts. Consider using a single background composable or adjusting alpha values to minimize overdraw. Test by enabling Debug GPU overdraw on a device.
Tech stack
kotlinandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Basic knowledge of Jetpack ComposeUnderstanding of GPU overdraw
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65