andreypopp/react-css-components

Allow className prop to apply classes to components

Open

#13 opened on Jul 13, 2016

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (676 stars) (23 forks)batch import
enhancementhelp wanted

Description

At the moment, if you import a component from your CSS, using the className prop to pass global classes in doesn't seem to work.

Is there a way to make these carry through to the underlying markup to allow things like global layout classes?

Contributor guide

Tech stack
reactcssjavascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactCSS ModulesProp forwarding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue requests that the `className` prop be forwarded to the underlying DOM elements. Investigate the component implementation in `src/`, likely using CSS Modules, to see how classes are currently applied. Ensure that the passed `className` is merged with the module's generated class. Review existing tests and update them to cover this case. Check for any breaking changes or edge cases with multiple class names.