andreamazz/AMScrollingNavbar

Bottom View popups issue on showNavBar when followerView exists

Open

#302 opened on Mar 6, 2018

View on GitHub
 (21 comments) (0 reactions) (0 assignees)Swift (632 forks)batch import
help wanted

Repository metrics

Stars
 (6,074 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://streamable.com/f7q3g

check the above video.

using:

UINavigationBar.appearance().isTranslucent = false

In Sampler / TableView

func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
    if let navigationController = self.navigationController as? ScrollingNavigationController {
      navigationController.showNavbar(animated: true, duration: 0.2)
   }
}

and

func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
cell.backgroundColor = .lightGray
}

I noticed there is a bottomView Poping from the bottom when using a follower View. This happens in two situations:

  1. when showNavBar is triggered.

  2. when checkForPartialScroll is triggered from semi to extened.

reproduce full code here: https://github.com/Alexookah/AMScrollingNavbar

Contributor guide

Research direction
Investigate the bottom view popup that occurs when showNavBar or checkForPartialScroll is called with a followerView present. Trace the scroll handling logic in the ScrollingNavigationController to find where the followerView's bottom constraint or animation might cause the popup.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
iOS developmentXcodeGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55