andlabs/libui

possibility: make it unnecessary to pass a function pointer into uiMainSteps()

Open

#147 opened on Jun 16, 2016

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C (10,632 stars) (610 forks)batch import
custom main loopsenhancementhelp wantedquestion

Description

split from #95

Actually looking at the GTK+ source code again, I wonder what would happen if I did this

diff --git a/unix/main.c b/unix/main.c
index bfd0544..0269d86 100644
--- a/unix/main.c
+++ b/unix/main.c
@@ -41,7 +41,8 @@ int uiMainStep(int wait)
    block = FALSE;
    if (wait)
        block = TRUE;
-   return gtk_main_iteration_do(block) == FALSE;
+   gtk_main_iteration_do(block);
+   return 1;
 }

 // gtk_main_quit() may run immediately, or it may wait for other pending events; "it depends" (thanks mclasen in irc.gimp.net/#gtk+)

and ran uiMainStep() without uiMainSteps(). @gnarz? I could also try this myself I guess... but if this does work I could probably just manage the running flag myself like I do on OS X and avoid the need for a function pointer.

Contributor guide

Tech stack
c
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Basic knowledge of CUnderstanding of GTK+ main loopFamiliarity with libui's main loop architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue proposes a change to `unix/main.c` to always return 1 from `uiMainStep()` instead of calling `gtk main iteration do()`. This would potentially eliminate the need for a function pointer in `uiMainSteps()`. To verify, test the modified code on Linux with GTK+, ensuring that `uiMainStep()` works correctly without `uiMainSteps()` and that no side effects occur. Also examine the OS X implementation for reference on managing the running flag. Relevant files: `unix/main.c` and possibly `osx/main.c`.