andersao/l5-repository

Unit tests

Open

#475 opened on Nov 14, 2017

View on GitHub
 (2 comments) (1 reaction) (1 assignee)PHP (4,119 stars) (868 forks)batch import
help wanted

Description

We need unit tests to facilitate collaboration and agility to accept the pull requests. Today the process is a bit arduous, due to the long delay to download the pull request, test and finally accept the PR.

Contributor guide

Tech stack
phplaravel
Domain
backendtesting
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PHPLaravelPHPUnitRepository pattern
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
First, examine the existing codebase in the src/ directory to understand the Repository classes and their dependencies. Then, look for any existing test setup or configuration (e.g., phpunit.xml, tests directory). Based on that, write unit tests for the core repository functionality, focusing on public methods. Consider using PHPUnit and perhaps Mockery for mocking. Check the comments in the issue for any maintainer guidance, but currently they are minimal.