andersao/l5-repository

Filter doesn't work with presenter

Open

#449 opened on Oct 8, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)PHP (4,119 stars) (868 forks)batch import
help wanted

Description

when i use presenter in repository class getting this result :

{{Url}}/bazaars?token={{token}}&filter=id;name

{
    "data": [
        {
            "id": 1,
            "name": "temp",
            "address": null,
            "city": null,
            "province_id": null
        },
        {
            "id": 2,
            "name": "temp1",
            "address": null,
            "city": null,
            "province_id": null
        }
]

but i need this:

{
    "data": [
        {
            "id": 1,
            "name": "temp",
        },
        {
            "id": 2,
            "name": "temp1"
        }
]

and i'm using fractal transformer.

Contributor guide

Tech stack
php
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Laravel basicsrepository patternfractal transformers
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate how the filter and presenter interact in the l5 repository package. Look at the Filter and Presenter traits to understand why fields are not being filtered when a presenter is used. Check the fractal transformer implementation to ensure filters are applied before transformation. Review any comments in the issue for additional context.