amoffat/supertag

Lints in clippy::restriction group are meant to be picked one by one

Open

#5 opened on Dec 3, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (26 forks)github user discovery
cleanupgood first issue

Repository metrics

Stars
 (616 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi @amoffat, thanks for this cool project!

I noticed you enabled the whole restriction category of Clippy. Lints in that group are not meant to be all enabled, as they are thought for very specific codebases, and some of them are even against idiomatic Rust. You should pick them one by one, if you find any of them useful.

Clippy should warn you against that, but you may be using an older version. Just wanted to make sure you are aware of that!

Contributor guide

Research direction
Locate the Clippy configuration file (e.g., .clippy.toml or Cargo.toml clippy section) and replace the `restriction` group with individual lints that are beneficial.
Tech stack
rust
Domain
cli
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90