Make Option impl more readable (use same code as for array impl)

Open Beginner friendly
#29 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
70/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
rust
Domain
devtools

Research direction

Open src/implementation.rs and compare the Option implementation at lines 315-356 with the array implementation at lines 25-37. Refactor the Option code to use the same, more readable structure while preserving its behavior. Review the resulting diff and run the repository's available Rust checks to confirm nothing else changes.

Written by the indexing model from the issue text.

Description

The code for Option
https://github.com/amethyst/serde-diff/blob/e461da41c9339af3ecadf9f4aa61ae91c1f79e97/src/implementation.rs#L315-L356
would be more readable if written like the code for arrays
https://github.com/amethyst/serde-diff/blob/e461da41c9339af3ecadf9f4aa61ae91c1f79e97/src/implementation.rs#L25-L37

Dominant language
Rust
Stars
127
Forks
22
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from amethyst/serde-diff

All issues in amethyst/serde-diff

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.