Wrong generic for `ReadExpect` makes the game crash

Open Beginner friendly
#220 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
rust
Domain
documentation

Research direction

Open book/src/chapter_54.md at the referenced line 173 and compare the generic used by ReadExpect. Change it from ReadExpect<'a, Position> to ReadExpect<'a, Point>, then run the tutorial and choose New Game to confirm the crash no longer occurs.

Written by the indexing model from the issue text.

Description

https://github.com/amethyst/rustrogueliketutorial/blob/33872fe582f226178436847e1f74eafcbf9c0d1a/book/src/chapter_54.md?plain=1#L173

This line should be ReadExpect<'a, Point> instead of ReadExpect<'a, Position>.
This actually makes the game crash after hitting New Game.

Dominant language
Rust
Stars
968
Forks
166
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from amethyst/rustrogueliketutorial

All issues in amethyst/rustrogueliketutorial

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.