amatt13/BossFight

Split RequestValidator.cs into multiple files with smaller scopes

Open

#32 opened on Mar 28, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (1 fork)auto 404
Back Endgood first issue

Repository metrics

Stars
 (1 star)
PR merge metrics
 (PR metrics pending)

Description

  1. Player actions:
  • PlayerCanSellWeapon()
  • PlayerCanEquipWeapon()
  • PlayerCanAttackMonsterWithEquippedWeapon()
  1. User authentication:
  • ValidateUserLoginCredentials()
  1. Chat messaging:
  • ValidateChatMessage()
  • ValidateMaxMessageRequestNumberNotExceeded()
  1. Game mechanics:
  • ValidateVoteForMonsterTier()
  1. Data validation:
  • AllValuesAreFilled()
  1. Database validation:
  • PlayerExists()
  • PlayerClassExists()
  • PlayerIsEligibleForPlayerClassAcquisition()
  • PlayerOwnsPlayerClass()

Contributor guide

Research direction
Identify each group of methods (player actions, authentication, etc.) and create separate partial class files or separate validation classes. Reference existing namespace and project structure.
Tech stack
csharp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65