alvarcarto/url-to-pdf-api

scrollPage bug

Open

#52 opened on Jan 2, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)HTML (6,967 stars) (759 forks)batch import
PR welcomehelp wanted

Description

There are some websites such as example using a special lazy loading strategy.

When users scroll quickly(<300ms) they do not load image. Just when users stop to look at the content they load image.

So, I think that we need another option (scrollInterval) to let user to test and decide the interval.

releated discussions:

https://github.com/GoogleChrome/puppeteer/issues/338#issuecomment-333301117

Thanks!

Contributor guide

Tech stack
javascriptnodejs
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of PuppeteerNode.js development environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the existing scrollPage implementation in the codebase, likely in a Puppeteer script. Look for where the scrolling logic is handled, and consider adding a new option `scrollInterval` that introduces a delay between scrolls. Reference the related discussion linked (https://github.com/GoogleChrome/puppeteer/issues/338#issuecomment 333301117) for implementation details. Test with the provided example website to ensure images load with the new option.