alteryx/henchman

Add test for missing values in diagnostics

Open

#26 opened on Sep 13, 2018

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Python (2 forks)auto 404
easyfixgood first issue

Repository metrics

Stars
 (15 stars)
PR merge metrics
 (PR metrics pending)

Description

  • Henchman version: 0.0.3

Description

The following lines loops are not run during tests

  • if duplicates.shape[0] > 0: (line 59)
  • if datacol.isnull().sum() > 0
    • Line 136 for the object column summary
    • Line 161 for boolean
    • Line 177 for numeric

Contributor guide

Research direction
Implement tests for the code paths handling missing values: duplicates shape > 0 and isnull checks for object, boolean, and numeric columns.
Tech stack
python
Domain
datatesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75