alteryx/evalml

Revert changes to testing with new XGBoost release

Open

#3,331 opened on Feb 15, 2022

View on GitHubContributor guide
 (0 comments) (0 reactions) (1 assignee)Python (93 forks)auto 404
good first issuetech debttesting

Repository metrics

Stars
 (852 stars)
PR merge metrics
 (PR metrics pending)

Description

In #3324 , we had to mark some tests as expected to fail since XGBoost was throwing a FutureWarning. The warning has been addressed in XGBoost, so we're just waiting for the PR merged to be released. This issue is discussed in the #3275 issue.

evalml/tests/component_tests/test_xgboost_classifier.py needs to have the @pytest.mark.xfail removed from the test_xgboost_catch_warnings_label_encoder test when XGBoost releases. EvalML will upgrade automatically when XGBoost releases, which should actually cause these tests to pass (and thus fail because of the xfail mark). Once the xfail is removed, this story is complete.

Contributor guide

Research direction
Check if the new XGBoost release is available, then remove the @pytest.mark.xfail decorator from the test xgboost catch warnings label encoder test and verify that the test passes.
Tech stack
python
Domain
testing qa
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85