allegro/axion-release-plugin

The plugin cannot detect changes in the repository (difference between 1.13.3 -> 1.13.4)

Open

#550 opened on Nov 4, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Groovy (628 stars) (161 forks)batch import
bughelp wanted

Description

I have a simple multi project build. I have a "root-project" that includes a "secondary-project". I would like to use the version of the "secondary-project". I used the repository.directory option:

scmVersion {
    repository {
        directory = new File(pathToSecondaryProject)
    }
}

With v1.13.3, it can detect that there are new commits in secondary-project and properly increments the version, but this doesn't work in newer versions, starting with 1.13.4: it gives me the version from the latest tag, without increasing. Setting ignoreUncommittedChanges = false, detects properly the uncommitted changes though. I looked at the commits but can't figure out what could cause the difference. Thank you!

Contributor guide

Tech stack
None
Domain
build systemrelease
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
GradleGitMulti project build
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the commits between version 1.13.3 and 1.13.4 of the axion release plugin, focusing on changes to the repository.directory option and ignoreUncommittedChanges flag. Look at the plugin's source code for how it detects commits in a specified directory. Also check if there were changes to the version calculation logic that could explain the regression.