allegro/axion-release-plugin

Deleted files are not committed

Open

#430 opened on Nov 1, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Groovy (628 stars) (161 forks)batch import
bughacktoberfesthelp wanted

Description

Hi, I'm currently trying to modify and delete files in post release hooks. Modifications and additions are committed and pushed successfully. Files are deleted but I cannot manage to commit the deletions. Is there such a possibility to do it in post release hook? If not perhaps it would be possible to add a property 'all' to ScmProperties to propagate it to Git? I mean like this:

boolean isAll = properties.getAll();
jgitRepository.commit().setAll(isAll).setMessage(message).call();

That would be really helpful

Thanks a lot!

Contributor guide

Tech stack
groovyjava
Domain
release
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
GroovyGradleJGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Look into the ScmProperties class in the axion release plugin repository to understand how properties are passed to the commit method. The issue suggests adding a getAll() method that propagates to JGit's setAll(). Examine the existing commit implementation in the plugin's Git related classes to see how to incorporate this change.