alibaba/pipcook

core: remove type assertion as possible

Open

#143 opened on Apr 27, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (212 forks)github user discovery
coregood first issue

Repository metrics

Stars
 (2,591 stars)
PR merge metrics
 (PR metrics pending)

Description

Type assertion allows us to override TypeSciprt's inference, and we should avoid using them to solve type conflicts manually, which means we should be careful with the use of assertions

Refer to:

Contributor guide

Research direction
Search the codebase for 'as' type assertions, especially in core modules, and replace with proper type annotations or type guards to avoid overriding TypeScript's inference.
Tech stack
typescript
Domain
backenddeveloper experience
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70