alibaba/lowcode-engine

renderer中pageRender调用getDerivedStateFromProps方法触发警告

Open

#2704 opened on Nov 28, 2023

View on GitHub
 (6 comments) (0 reactions) (1 assignee)TypeScript (12,714 stars) (2,228 forks)batch import
help wanted

Description

当对renderer做二次封装时，会出现如下warnning： image

初步判定PageRenderer调用getDerivedStateFromProps方法时，excuteLifeCycleMethod返回了undefined，而不是一个空值null，导致static方法getDerivedStateFromProps报错。

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React lifecycleTypeScript basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is a bug in the PageRenderer where executeLifeCycleMethod returns undefined instead of null for getDerivedStateFromProps. The fix is in the renderer source code, likely in the file handling lifecycle methods. The screenshots show the relevant code. Look for the executeLifeCycleMethod function and modify it to return null when the result is undefined. Ensure the change aligns with React's expected return values for getDerivedStateFromProps.