alibaba/Sentinel

Add global fallback support for AspectJ annotation extension

Open

#3,110 opened on Apr 27, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (23,109 stars) (8,150 forks)batch import
area/annotationgood first issuekind/feature

Description

Issue Description

Type: feature request

Describe what feature you want

Add global fallback support for AspectJ annotation extension.

@SentinelResource 注解方式埋点支持全局自定义 fallback，作为通用的兜底 fallback。在这个场景下，即使没有在 @SentinelResource 中指定 fallback 和 defaultFallback，只要在创建 SentinelResourceAspect 时指定了全局自定义 fallback，在出现异常或流量防护触发时 也会走到全局自定义 fallback 中。

Describe your initial design (if present)

Add an interface like this, and support creating SentinelResourceAspect with it:

public interface SentinelAnnotationGlobalFallback {

    Object handle(Method originalMethod, Object[] args, Throwable t) throws Throwable;
}

Contributor guide

Tech stack
java
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaAspectJSpring AOP basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests adding a global fallback interface `SentinelAnnotationGlobalFallback` and modifying `SentinelResourceAspect` to accept it. The implementation involves creating the interface and updating the aspect logic to call the global fallback when no specific fallback is defined. Key files include `SentinelResourceAspect.java`. The maintainer may have additional feedback in the single comment. Review existing fallback handling in the aspect and ensure thread safety.