alibaba/Sentinel

[Benchmark] 1.8.5版本 benchmark性能损耗严重 | performance not well in Sentinel 1.8.5 compared with 1.7.x

Open

#2,902 opened on Oct 12, 2022

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Java (23,109 stars) (8,150 forks)batch import
area/benchmarkarea/performancehelp wanted

Description

测试场景：在4C8G机器下跑com.alibaba.csp.sentinel.benchmark.SentinelEntryBenchmark的testSingleThreadDirectly、testSingleThreadSingleEntry 对比1.8.5和1.7.0，发现1.8.5性能损耗较严重

组长度 1.8.5 Baseline (QPS) 1.8.5 With Sentinel (QPS) 1.8.5 性能损耗 1.7.0 Baseline (QPS) 1.7.0 With Sentinel (QPS) 1.7.0 性能损耗 官方 Baseline (QPS) 官方 With Sentinel (QPS) 官方 性能损耗
length=25 524112.631 277096.821 47.13% 551245.089 364269.65 33.92% 604589.916 401687.765 33.56%
length=50 205371.625 151465.386 26.25% 213939.277 179810.663 15.95% 221307.617 192407.832 13.06%
length=100 89676.053 78605.025 12.35% 92361.784 85894.033 7.00% 97673.228 91535.146 6.28%
length=200 40003.392 37519.764 6.20% 41446.589 39917.156 3.69% 43742.96 42711.129 2.36%
length=500 13942.424 13677.998 1.90% 14563.868 14378.434 1.27% 15332.924 15171.024 1.06%
length=1000 6392.317 6282.31 1.72% 6624.78 6588.871 0.54% 7012.848 6984.036 0.41%

Contributor guide

Tech stack
java
Domain
performancebackend
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaJMH (Java Microbenchmark Harness)Sentinel internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Start by reproducing the benchmark results using the provided test methods in `SentinelEntryBenchmark.java`. Investigate the performance regression by comparing the code changes between version 1.7.0 and 1.8.5. Focus on the entry creation and rule checking paths. Use profiling tools like Java Flight Recorder to identify hotspots. Look at recent commits that might have introduced overhead, especially related to rule parsing or caching.