alibaba/Sentinel

SentinelResourceAspect can not get @SentinelResource annotation in Proxy Interface

Open

#284 opened on Dec 5, 2018

View on GitHub
 (7 comments) (0 reactions) (1 assignee)Java (8,150 forks)batch import
area/annotationgood first issuekind/bug

Repository metrics

Stars
 (23,109 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Issue Description

I can not get @SentinelResource annotation property from Method in SentinelResourceAspect when I use a Proxy Interface(EchoService) that created by java.lang.reflect.Proxy.

public interface EchoService {
    @SentinelResource(value = "testResource")
    String echo(String str);
}

Type: bug report

Describe what happened (or what feature you want)

image

Contributor guide

Research direction
Investigate how to retrieve annotations from proxy interfaces in Spring AOP aspects. Look at `Method.getDeclaringClass()` and consider using `AnnotationUtils.findAnnotation()` or checking the interfaces.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaSpring AOP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60