alibaba/Sentinel

sentinel springwebmvc不支持异步async请求

Open

#2447 opened on Nov 12, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (23,109 stars) (8,150 forks)batch import
area/integrationsgood first issuekind/bug

Description

我们在Controller使用了WebAsyncTask的异步返回方式，这种情况下，AbstractSentinelInterceptor中的prehandle会执行两次，rckey变成了2，但是afterCompletion只会执行一次（而且还是在另外一个线程请求的），导致clean的逻辑无法执行，这样entry和context在threadlocal中一直无法清除，最终oom

Contributor guide

Tech stack
javaspring
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaSpring Web MVCSentinelAsync request handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the AbstractSentinelInterceptor class in Sentinel's Spring Web MVC integration. Focus on how preHandle and afterCompletion are called for async requests (WebAsyncTask). Check the thread local management for entry and context. Consider adding async support similar to Spring's async handler interceptor pattern. Also examine existing test cases for async endpoints. Might need to ensure afterCompletion is called on the original thread or handle cleanup appropriately.