alibaba/Sentinel

Flaky test in SentinelDubboConsumerFilterTest (sentinel-apache-dubbo-adapter module)

Open

#1,995 opened on Feb 1, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (8,150 forks)batch import
area/testgood first issue

Repository metrics

Stars
 (23,109 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Issue Description

Type: bug report

Describe what happened (or what feature you want)

Flaky test in com.alibaba.csp.sentinel.adapter.dubbo.SentinelDubboConsumerFilterTest:

[INFO] Running com.alibaba.csp.sentinel.adapter.dubbo.SentinelDubboConsumerFilterTest
[ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.271 s <<< FAILURE! - in com.alibaba.csp.sentinel.adapter.dubbo.SentinelDubboConsumerFilterTest
[ERROR] testDegradeAsync(com.alibaba.csp.sentinel.adapter.dubbo.SentinelDubboConsumerFilterTest)  Time elapsed: 0.069 s  <<< FAILURE!
org.junit.ComparisonFailure: expected:<[fallback]> but was:<[normal]>
	at com.alibaba.csp.sentinel.adapter.dubbo.SentinelDubboConsumerFilterTest.testDegradeAsync(SentinelDubboConsumerFilterTest.java:115)

[INFO] Running com.alibaba.csp.sentinel.adapter.dubbo.DubboUtilsTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.033 s - in com.alibaba.csp.sentinel.adapter.dubbo.DubboUtilsTest
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   SentinelDubboConsumerFilterTest.testDegradeAsync:115 expected:<[fallback]> but was:<[normal]>

Contributor guide

Research direction
Inspect the test method testDegradeAsync and understand the async invocation flow. Look for race conditions between applying the degrade rule and the async response. Consider adding synchronization or a latch to ensure the rule is effective before the async call returns.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65