alibaba/Sentinel

About AuthorityRuleChecker.The PassCheck() method implementation problem

Open

#1,753 opened on Sep 23, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (8,150 forks)batch import
good first issue

Repository metrics

Stars
 (23,109 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Type: bug report

Describe what happened (or what feature you want)

This class is primarily used to determine the match of the context rules corresponding to the resource.Why do I need to repeat the validation with indexOf() and EQUALS methods?

Anything else we need to know?

com.alibaba.csp.sentinel.slots.block.authority.AuthorityRuleChecker

Contributor guide

Research direction
Inspect the AuthorityRuleChecker.PassCheck() method implementation to understand the redundant use of indexOf() and equals() for rule matching. Determine if there is a bug or if it's intentional; suggest removing the redundant check.
Tech stack
java
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaSentinel basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40