alibaba/Sentinel

Flaky test cases in sentinel-parameter-flow-control module

Open

#1,752 opened on Sep 22, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (8,150 forks)batch import
area/testgood first issuehelp wanted

Repository metrics

Stars
 (23,109 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Issue Description

Type: bug report

Describe what happened (or what feature you want)

Flaky unstable test in com.alibaba.csp.sentinel.slots.block.flow.param.ParamFlowDefaultCheckerTest

[ERROR] Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.823 s <<< FAILURE! - in com.alibaba.csp.sentinel.slots.block.flow.param.ParamFlowDefaultCheckerTest
[ERROR] testParamFlowDefaultCheckSingleValueCheckQpsMultipleThreads(com.alibaba.csp.sentinel.slots.block.flow.param.ParamFlowDefaultCheckerTest)  Time elapsed: 4.063 s  <<< FAILURE!
java.lang.AssertionError: expected:<6> but was:<5>
	at com.alibaba.csp.sentinel.slots.block.flow.param.ParamFlowDefaultCheckerTest.testParamFlowDefaultCheckSingleValueCheckQpsMultipleThreads(ParamFlowDefaultCheckerTest.java:323)

[INFO] Running com.alibaba.csp.sentinel.slots.statistic.metric.HotParameterLeapArrayTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.064 s - in com.alibaba.csp.sentinel.slots.statistic.metric.HotParameterLeapArrayTest
[INFO] Running com.alibaba.csp.sentinel.slots.statistic.data.ParamMapBucketTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 s - in com.alibaba.csp.sentinel.slots.statistic.data.ParamMapBucketTest
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   ParamFlowDefaultCheckerTest.testParamFlowDefaultCheckSingleValueCheckQpsMultipleThreads:323 expected:<6> but was:<5>
[INFO] 
[ERROR] Tests run: 32, Failures: 1, Errors: 0, Skipped: 0

Describe what you expected to happen

The test case should not fail.

How to reproduce it (as minimally and precisely as possible)

Tell us your environment

https://app.circleci.com/pipelines/github/alibaba/Sentinel/473/workflows/ce91869c-8bf7-457e-ba0e-7c0f43dc3c1e/jobs/2520

Anything else we need to know?

Contributor guide

Research direction
Examine the test method testParamFlowDefaultCheckSingleValueCheckQpsMultipleThreads for timing or concurrency issues. The assertion expects 6 but got 5, indicating a race condition. Check if the test setup or metric collection needs synchronization.
Tech stack
java
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaJUnitSentinel flow control
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60