alibaba/Sentinel

Sentinel gRPC support for Streaming RPC

Open

#1,662 opened on Aug 12, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (8,150 forks)batch import
area/integrationsgood first issue

Repository metrics

Stars
 (23,109 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Issue Description

Type: feature request

Describe what happened (or what feature you want)

We are trying to integrate Sentinel with gRPC client for Circuit Breaker capabilities, using interceptor 'SnetinelGrpcClientInterceptor'. We have noticed that it is documented that - 'interceptor only supports unary methods in gRPC' we would like to know if you have any plans in extending the support for gRPC Streaming methods.

Contributor guide

Research direction
Extend the existing SentinelGrpcClientInterceptor to handle streaming RPCs by implementing the appropriate gRPC listener methods for server streaming, client streaming, and bidirectional streaming. Study the gRPC Java API for ClientInterceptor and ServerInterceptor, and understand how Sentinel currently handles unary calls. Then add streaming support by wrapping the stream observer or listener.
Tech stack
javagrpc
Domain
backendapicloud
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavagRPCSentinel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60