alibaba/Sentinel

Flaky test cases in sentinel-demo-quarkus module

Open

#1,623 opened on Jul 22, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (8,150 forks)batch import
area/testgood first issue

Repository metrics

Stars
 (23,109 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Issue Description

Type: bug report

Describe what happened (or what feature you want)

Flaky unstable test in com.alibaba.csp.sentinel.demo.quarkus.GreetingResourceTest.testSentinelJaxRsQuarkusAdapter:

ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 5.589 s <<< FAILURE! - in com.alibaba.csp.sentinel.demo.quarkus.GreetingResourceTest
[ERROR] testSentinelJaxRsQuarkusAdapter  Time elapsed: 1.048 s  <<< FAILURE!
java.lang.AssertionError: 
1 expectation failed.
Expected status code <429> but was <200>.

	at com.alibaba.csp.sentinel.demo.quarkus.GreetingResourceTest.testSentinelJaxRsQuarkusAdapter(GreetingResourceTest.java:45)

2020-07-22 03:10:31,055 INFO  [io.quarkus] (main) Quarkus stopped in 0.027s
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   GreetingResourceTest.testSentinelJaxRsQuarkusAdapter:45 1 expectation failed.
Expected status code <429> but was <200>.

https://app.circleci.com/pipelines/github/alibaba/Sentinel/264/workflows/fd9ae813-fef6-416c-8a0d-65c55b95275d/jobs/2093

Describe what you expected to happen

The test case should not fail.

Contributor guide

Research direction
Investigate the flaky test by adding synchronization or increasing wait time in the Quarkus test.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaMaven
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60