alibaba/Sentinel

一点关于UrlCleaner的改进建议和意见

Open

#1287 opened on Feb 14, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Java (23,109 stars) (8,150 forks)batch import
area/integrationsgood first issuekind/enhancement

Description

这里，UrlCleaner特指sentinel-spring-webmvc-adapter中的UrlCleaner： https://github.com/alibaba/Sentinel/blob/master/sentinel-adapter/sentinel-spring-webmvc-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/spring/webmvc/callback/UrlCleaner.java

个人认为有两点值得改进：

  • UrlCleaner名称词不达意。UrlCleaner重写的不是Url，而是资源名称，叫ResourceNameRewiter或许更加贴切。

  • 目前UrlCleaner提供的参数较少，能定制的空间很小。目前只能在原资源名称的基础上改写资源。但实际业务中，往往需要根据具体的请求重写资源名称。因此，加上 HttpServletRequest 的参数灵活性会好很多。

Contributor guide

Tech stack
javaspring
Domain
backendapisecurity
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic JavaSpring MVCUnderstanding of Sentinel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the UrlCleaner interface in sentinel spring webmvc adapter. Discuss with maintainers whether the rename and additional HttpServletRequest parameter are acceptable. Review any existing implementations and tests that need updating.