alibaba/GraphScope

[BUG] Use jar-with-dependencies to package frontend artifacts in GIE

Open

#2,938 opened on Jun 27, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)HTML (2,401 stars) (301 forks)batch import
component:dev-infracomponent:giegood first issuejavapriority:high

Description

Describe the bug

It is quite superised that we didn't use jar-with-dependency to package the release artifacts for java. Recent changes about neo4j introduced some new jar dependency, double the size of the wheel package (https://pypi.org/project/graphscope/0.23.0a20230625/#files), makes graphscope hard to install with python ....

Expected Outcome

The ultimate goal is to reduce the size of wheels, which in this issue, is the artifacts of interactive engine. You could observe the size of artifacts of gie by make interactive and find graphscope.tar.gz within interactive_engine/assembly/target

Additional context Add any other context about the problem here.

Contributor guide

Tech stack
java
Domain
build system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
MavenJava packaging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the current Maven packaging configuration in the interactive engine assembly module (likely in interactive engine/assembly/pom.xml). Modify the pom.xml to use the jar with dependencies classifier to bundle dependencies into a single jar. Then run 'make interactive' to verify the build and check the size of graphscope.tar.gz in interactive engine/assembly/target. Ensure that the wheel package size is reduced as expected.
[BUG] Use jar-with-dependencies to package frontend artifacts in GIE · alibaba/GraphScope#2938 | Good First Issue