alibaba/GraphScope

[BUG] g.graphlearn()/g.gremlin() should check if the type is compatible first

Open

#1,509 opened on May 6, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)HTML (2,401 stars) (301 forks)batch import
component:pythonenhancementgood first issue

Description

Describe the bug

GraphLearn has implies int64_t as OID_T (see types.h) and current gremlin engine doesn't support string oids as well (see https://github.com/alibaba/GraphScope/issues/1265).

An exceptions should be thrown in g.graphlearn()/g.gremlin() is the oid type of vineyard graph is not compatible with those two engines.

Contributor guide

Tech stack
cpp
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic C++understand OID typesfamiliarity with GraphScope codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate the g.graphlearn() and g.gremlin() functions in the GraphScope codebase to identify where to add the type compatibility check. Refer to the types.h file (graphlearn/core/graph/storage/types.h) which defines OID T as int64 t. The exception should be thrown when the vineyard graph's OID type is not compatible. Also consider checking the linked issue #1265 for context on gremlin engine limitations. The fix should be localized and throw an appropriate error message.