alexcasalboni/ssm-cache-python

Improve "internal" consistency for individual params of a group

Open

#16 opened on Feb 28, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (20 forks)github user discovery
enhancementhelp wantedquestion

Repository metrics

Stars
 (209 stars)
PR merge metrics
 (Avg merge 9d 9h) (3 merged PRs in 30d)

Description

_max_age and _last_refresh_time are not currently "shared" between a SSMParameterGroup and its SSMParameter objects.

While #14 has fixed the refreshing bug due to this inconsistency, we could somehow keep the internal Refreshable fields in sync between a group and its parameters to avoid more problems in the future. The current solution always delegates _should_refresh to the group.

Contributor guide

Research direction
Implement synchronization of ` max age` and ` last refresh time` fields between `SSMParameterGroup` and `SSMParameter` objects, perhaps by overriding property setters or using a shared state.
Tech stack
python
Domain
backendcloud
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50