alexaubry/BulletinBoard

seeking suggestions for handling rotation

Open

#92 opened on Jun 27, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Swift (4,908 stars) (271 forks)batch import
enhancementhelp wanted

Description

Some of my taller Bulletin Board items render poorly when the phone is rotated. It happens when the description text is long, and especially when an image is set. Typically, the label is truncated to a single line, the primary button is shrunk to a minimum size, and the secondary button is pushed off screen. It is possible to scroll but it does not work well and is not intuitive.

I'm wondering if or how other folks are dealing with rotation. Turning it off for the app is not an option.

Would it be possible to expose supportedInterfaceOrientations() from the BulletinBoardManager? That seems like the simplest change. I also thought about trying to expose more of the stack view, or constraints on the ui elements, or improving the scrolling behavior.

Contributor guide

Tech stack
swift
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
iOS development basicsUIKit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate how to expose `supportedInterfaceOrientations()` from the `BulletinBoardManager` to allow customization. Review the current implementation in the repository, particularly the `BulletinBoardManager` class and the view controller hierarchy. Consider adding a delegate method or a property to allow clients to specify supported orientations. Check existing comments for additional insights on scrolling behavior improvements.