alexaubry/BulletinBoard

assertIsPrepared() being called randomly

Open

#113 opened on Sep 25, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Swift (4,908 stars) (271 forks)batch import
bughelp wanted

Description

Problem Description: My app would randomly crash due to assertIsPrepared() being called. Is this a known bug or am I doing something wrong?

fileprivate func assertIsPrepared() {
    precondition(isPrepared, "You must call the `prepare` function before interacting with the bulletin.")
}

Steps to reproduce: This is what I call when a button is pressed:

bulletinManager.backgroundViewStyle = .none
bulletinManager.backgroundColor =  UIColor(red:0.30, green:0.69, blue:0.94, alpha:1.00)
bulletinManager.showBulletin(above: self)

The crash seems random.

Environment:

  • Device: N/A
  • OS: iOS12
  • Version of BulletinBoard: 2.0.2

Contributor guide

Tech stack
swift
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
SwiftiOS developmentBulletinBoard usage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the `assertIsPrepared` function to understand the precondition check. Look into the `showBulletin(above:)` method and the `prepare` lifecycle to identify potential race conditions. Review the issue comments for any additional reproduction steps or hints about threading. Since the crash is random, focus on the setup of `BulletinManager` properties before calling `showBulletin`.