alanshaw/david-www

Badge colour always green when all dependencies pinned

Open

#48 opened on Jul 16, 2013

View on GitHub
 (2 comments) (2 reactions) (0 assignees)JavaScript (733 stars) (177 forks)batch import
bughelp wantedquestion

Description

At the moment David considers tags, absolute versions (i.e. not semver ranges) and URLs as pinned dependencies. The idea being that the author wants to use a specific version because higher versions don't contain the same functionality (the author doesn't have a choice not to use the dependency at that version) or because it is a custom build of the module (for a URL dependency) or for some other reason. Pinned dependencies don't normally count towards your David badge, but when an author has pinned all dependencies to specific versions the reasoning behind not counting pinned dependencies towards your badge is incorrect, since if all dependencies are pinned the badge will always be green.

I propose that when all dependencies are pinned, absolute versions should affect the David badge colour.

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of semver and dependency pinning concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Review the badge generation code in the repository, likely in a file such as lib/badge.js or similar. Understand how pinned dependencies are currently excluded from badge calculation. Modify the logic to count pinned dependencies when all are pinned. Ensure to update corresponding tests and check for any edge cases.