akxcv/vuera

Distribution file compatibility

Open

#29 opened on Feb 22, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (4,260 stars) (264 forks)batch import
good first issuehelp wanted

Description

This issue came up because of IE11, but I totally understand if including support for IE11 is not something within the scope of this library. It looks like es2015 compatibility is desired based on the .babelrc:

https://github.com/akxcv/vuera/blob/30ab626d8105ed8b2223ca2aa45495daa112529a/.babelrc#L6

However, both Object.assign and Object.entries appear in the built common js file:

https://github.com/akxcv/vuera/blob/30ab626d8105ed8b2223ca2aa45495daa112529a/dist/vuera.cjs.js#L229

https://github.com/akxcv/vuera/blob/30ab626d8105ed8b2223ca2aa45495daa112529a/dist/vuera.cjs.js#L451

I always forget which level Object.assigns is at, but I believe Object.entries is much more recent? Is this maybe a bug in the rollup or babel configuration during the build?

Thanks!

Contributor guide

Tech stack
javascriptreactvue
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
understanding of ES5/ES6 featuresfamiliarity with Babel configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the .babelrc file at line 6 to see the target environment configuration. Check the rollup config to understand how the dist files are built. Determine if Object.assign and Object.entries need to be polyfilled or if the build targets should be adjusted to avoid these modern methods.