akveo/ngx-admin

AnalyticsService check that ga function exists

Open

#5523 opened on Oct 2, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (24,990 stars) (7,916 forks)batch import
P4: nice to havebughelp wantedneeds triage

Description

Issue type

I'm submitting a ... (check one with "x")

  • [ X] bug report
  • feature request
  • question about the decisions made in the repository

Issue description

Current behavior:

error in console while ad-blocker is active

Expected behavior:

No error (or maybe a log that tells that GA is not available Steps to reproduce:

  1. Enable analytics
  2. Run when ad-blocker is on

Related code:

insert short code snippets here

Other information:

npm, node, OS, Browser

<!--
Node, npm: `node --version` and `npm --version`
OS: Windows (7/8/10). Linux (incl. distribution). macOS (El Capitan? Sierra?)
Browser: Chrome/Safari/Firefox/etc?
-->

Angular, Nebular

<!--
Check your `package-lock.json` or locate a `package.json` in the `node_modules` folder.
-->

Contributor guide

Tech stack
angulartypescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of TypeScriptFamiliarity with Angular services
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue is to add a null check for the global `ga` function in the AnalyticsService to prevent console errors when an ad blocker is active. Look in `src/app/@core/utils/analytics.service.ts` for where `ga` is called. Add an if statement to check if `typeof ga !== 'undefined'` before invoking it. Also consider adding a console.warn when GA is not available. The issue has 2 comments which may provide additional context; review them for any suggested approach. No linked PRs.