aksonov/react-native-router-flux

Actions.pop always return true

Open

#3337 opened on Oct 30, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (8,999 stars) (2,112 forks)batch import
bughelp wanted

Description

Version

Tell us which versions you are using:

  • react-native-router-flux v4.0.4
  • react v16.2.0
  • react-native v0.53.3

Expected behaviour

In RNRF v4.0.0-bate25, Actions.pop return false if the sence is the first page, but 4.0.4 always return true.How do I tell if my stack is currently empty?

Actual behaviour

As above

Contributor guide

Tech stack
javascriptreact nativereact
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of React Native navigationFamiliarity with react native router flux APIBasic JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the Actions.pop implementation in the library's source code, likely in the core router file. The pop method should check if there is only one scene in the stack and return false in that case. Look for any recent changes that might have removed this check. Test with a minimal React Native app using the library and verify that Actions.pop returns false when navigation stack has only one scene.