akka/akka-http

Use splitAfter in Websocket.scala

Open

#96 opened on Sep 8, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Scala (598 forks)batch import
1 - triagedhelp wantedsmallt:server

Repository metrics

Stars
 (1,311 stars)
PR merge metrics
 (Avg merge 1d 10h) (2 merged PRs in 30d)

Description

Issue by ktoso Monday Jan 04, 2016 at 20:10 GMT Originally opened as https://github.com/akka/akka/issues/19348

As commented there it should simplify the flows a bit:

.splitWhen(_.isMessageEnd) // FIXME using splitAfter from #16885 would simplify protocol a lot

https://github.com/spray/akka/commit/6980a0ba61291cb71064267c1b7864de96ddd01a#diff-32111086a8e0b3bf2b812bda44d7c0a1R116

Contributor guide

Research direction
Locate the Websocket.scala file, find the splitWhen call in the protocol handling, and replace it with splitAfter after understanding the API differences.
Tech stack
scala
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ScalaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50