akka/akka-http

Impossible to parse cyrillic Uri

Open

#86 opened on Sep 8, 2016

View on GitHub
 (14 comments) (3 reactions) (0 assignees)Scala (598 forks)batch import
1 - triagedhelp wantedt:coret:model

Repository metrics

Stars
 (1,311 stars)
PR merge metrics
 (Avg merge 1d 10h) (2 merged PRs in 30d)

Description

Issue by RomanIakovlev Tuesday Feb 02, 2016 at 19:17 GMT Originally opened as https://github.com/akka/akka/issues/19677

Consider this:

"com.typesafe.akka" %% "akka-http-experimental" % "2.4.2-RC1"

import akka.http.scaladsl.model.Uri

scala> Uri("http://президент.рф/", Uri.ParsingMode.Relaxed)
akka.http.scaladsl.model.IllegalUriException: Illegal URI reference: Invalid input 'п', expected 'EOI', '#', '?', path-abempty or authority (line 1, column 8): http://президент.рф/
       ^
  at akka.http.scaladsl.model.IllegalUriException$.apply(ErrorInfo.scala:40)
  at akka.http.scaladsl.model.Uri$.fail(Uri.scala:741)
  at akka.http.impl.model.parser.UriParser.fail(UriParser.scala:62)
  at akka.http.impl.model.parser.UriParser.parseUriReference(UriParser.scala:33)
  at akka.http.scaladsl.model.Uri$.apply(Uri.scala:209)
  at akka.http.scaladsl.model.Uri$.apply(Uri.scala:199)
  ... 43 elided

Any insights on how to tackle this?

Contributor guide

Research direction
Inspect the UriParser code to understand how it handles non ASCII characters in URIs. Focus on the parsing mode and the logic that rejects Cyrillic characters. Consider adding support for Internationalized Resource Identifiers (IRI) or implementing a relaxed mode that allows UTF 8 characters.
Tech stack
scala
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ScalaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65