akka/akka-http

HTTP2: Respect SETTINGS_ENABLE_PUSH

Open

#775 opened on Jan 16, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Scala (598 forks)batch import
1 - triagedhelp wantedt:http2

Repository metrics

Stars
 (1,311 stars)
PR merge metrics
 (Avg merge 1d 10h) (2 merged PRs in 30d)

Description

SETTINGS_ENABLE_PUSH (0x2): This setting can be used to disable server push (Section 8.2).

  • An endpoint MUST NOT send a PUSH_PROMISE frame if it receives this parameter set to a value of 0.
  • (client) An endpoint that has both set this parameter to 0 and had it acknowledged MUST treat the receipt of a PUSH_PROMISE frame as a connection error (Section 5.4.1) of type PROTOCOL_ERROR.

The initial value is 1, which indicates that server push is permitted. Any value other than 0 or 1 MUST be treated as a connection error (Section 5.4.1) of type PROTOCOL_ERROR.

Contributor guide

Research direction
Implement logic to respect SETTINGS ENABLE PUSH from remote peer: when receiving a SETTINGS frame with ENABLE PUSH=0, the endpoint must not send PUSH PROMISE frames and must treat incoming PUSH PROMISE as a connection error. Locate the HTTP/2 implementation in akka http and add the necessary state checks and error handling.
Tech stack
scala
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ScalaHTTP/2
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40