akka/akka-http

Use override keyword more prominently in Http codebase

Open

#72 opened on Sep 8, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Scala (598 forks)batch import
1 - triagedhelp wantednice-to-have (low-prio)

Repository metrics

Stars
 (1,311 stars)
PR merge metrics
 (Avg merge 1d 10h) (2 merged PRs in 30d)

Description

Issue by ktoso Wednesday Mar 09, 2016 at 15:08 GMT Originally opened as https://github.com/akka/akka/issues/19986

In general the HTTP codebase does not use the override keyword too much. AFAIR we had some discussions and were moving towards using it more, anyway most important is to be consistent so this should be applied over the entire codebase.

One instance of such places here: https://github.com/akka/akka/pull/19984

Contributor guide

Research direction
Identify all method definitions that override a superclass or trait method and are missing the 'override' modifier, then add the keyword.
Tech stack
scala
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitScala
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70