akka/akka-http

Construct `ToResponseMarshaller` from `Marshaller[A, ResponseEntity]`

Open

#642 opened on Dec 11, 2016

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Scala (1,311 stars) (598 forks)batch import
1 - triagedhackathonhelp wantedt:javat:marshallingt:routing

Description

Currently only Marshaller[A, MessageEntity] is supported, which is Marshaller[A, RequestEntity], which won't for work for all ResponseEntitys (namely CloseDelimited).

Related #641.

Contributor guide

Tech stack
None
Domain
api
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Akka HTTP marshallingFamiliarity with Response types
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the current implementation of `ToResponseMarshaller` in the akka http codebase. The issue references #641, which likely discusses the limitation. Look at the `Marshaller` trait and the existing `MessageEntity` support. To add support for `ResponseEntity`, you need to understand how `CloseDelimited` and other types are handled. The fix likely involves adding a new implicit conversion or extending the marshalling logic.