akka/akka-http

Bump h2spec external binary to newer versions

Open

#3,534 opened on Oct 15, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Scala (1,311 stars) (598 forks)batch import
help wantednice-to-have (low-prio)t:http2

Description

In #1578 there was some initial work to update the build to use a newer version of https://github.com/summerwind/h2spec/. That work focused on the build.

I've just replaced the binary in ./akka-http2-support/target/h2spec_darwin_amd64/h2spec with the latest and ran H2SpecIntegrationSpec. Tests, as they are now, fail because the binary API has changed from:

https://github.com/summerwind/h2spec/tree/9b3d1a5078cb4003506bd8004eb1b01e3be2a3e7

to

https://github.com/summerwind/h2spec/#usage

The parameter -s: Section number on which to run the test. (Example: -s 6.1 -s 6.2) is not available in h2spec since version 2.0.0. As a consequence, the execution of H2SpecIntegrationSpec goes over tests we don't need taking (a lot) longer and reporting failures we would ignore anyway.

Contributor guide

Tech stack
None
Domain
testingbuild system
Issue type
chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of HTTP/2Familiarity with h2spec tool
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the current h2spec CLI changes between version 1.x and 2.x. The old API used s to specify sections, which is no longer available. Update the H2SpecIntegrationSpec test configuration to use the new CLI arguments, likely involving different flags or a separate configuration file. Check the h2spec repository usage documentation for the correct syntax and adapt the test runner accordingly.