akka/akka-http

Problem with query parameter separator

Open

#2,854 opened on Dec 9, 2019

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Scala (598 forks)batch import
1 - triageddiscusshelp wantedt:coret:model

Repository metrics

Stars
 (1,311 stars)
PR merge metrics
 (Avg merge 1d 10h) (2 merged PRs in 30d)

Description

After moving Play Framework from version 2.4 to 2.7 and starting to use akka-http as the server we encountered one problem with some weird URLs that we were mistakenly generating.

This url http://localhost:9000/issue/1300068591272/_lines?projectId=22877&commitId=15565520 reached the server with query parameter called projectId and commitId while this url http://localhost:9000/issue/1300068591272/_lines?projectId=22877&commitId=15565520 does not get the second.

Seems like this might be related to the way akka-http parses URLs. Apparently the second URL is also valid because at least ; is a supported separator.

I would gladly fix this if you point me in the right direction.

References:

Contributor guide

Research direction
Investigate how akka http parses query parameters, specifically the handling of semicolons as separators as per RFC 3986 and HTML spec. Look at the parsing code for query strings and ensure that '&' and ';' are treated as separators.
Tech stack
scala
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Scala
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60