akka/akka-http

JsonEntityStreamingSupport duplicated

Open

#2,057 opened on Jun 7, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Scala (1,311 stars) (598 forks)batch import
1 - triagedhelp wantedt:marshalling

Description

It seems JsonEntityStreamingSupport is duplicated between akka-http-spray-json and akka-http. We probably can't remove this duplication for now, but at least we should see if we can make one of them deprecated.

Contributor guide

Tech stack
scala
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Scalaakka http
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The duplicate `JsonEntityStreamingSupport` class exists in both the `akka http spray json` and `akka http` modules. First, locate the source files (likely named `JsonEntityStreamingSupport.scala` in each module) and compare their implementations. Check how each is imported and used across the codebase. Then, propose deprecating one version by adding a `@deprecated` annotation and update documentation accordingly. The single comment on the issue suggests discussing on the mailing list if uncertain about which to deprecate.