akka/akka-http

Potential inconsistency in Uri API

Open

#1,763 opened on Jan 9, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Scala (1,311 stars) (598 forks)batch import
1 - triaged3 - in progresshelp wantedt:coret:model

Description

The different smart constructors to create an akka.http.scaladsl.model.Uri have a different behavior regarding the port normalization.

The apply methods don't normalize the Authority port, unlike the from method:

scala> import akka.http.scaladsl.model.Uri
import akka.http.scaladsl.model.Uri

scala> Uri("http://www.google.fr:80")
res0: akka.http.scaladsl.model.Uri = http://www.google.fr:80

scala> Uri.from(scheme = "http", host = "www.google.fr", port= 80)
res1: akka.http.scaladsl.model.Uri = http://www.google.fr

As a side note Spray was normalizing the port on all Uri smart constructors.

Contributor guide

Tech stack
scala
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with ScalaUnderstanding of Akka HTTP Uri constructors
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the source code of `Uri` in `akka http core/src/main/scala/akka/http/scaladsl/model/Uri.scala` to understand the `apply` and `from` methods. Check if there is existing normalization logic for ports. Look at the test files for Uri to ensure consistency. Consider whether the fix should add normalization to `apply` or remove it from `from`.