akka/akka-http

HTTP request parser returns error if Host header has empty field-value

Open

#1,530 opened on Nov 14, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Scala (1,311 stars) (598 forks)batch import
1 - triagedhelp wantedt:coret:server

Description

HTTP/1.1 allows the host header in requests to have an empty field value. However, if Akka HTTP server receives a request with a host header with an empty field value, it behaves as if the request had no host header.

Reproduction steps: Run the sample Akka HTTP server and run curl -H 'Host: ' 'http://localhost:8080/hello' Expected: The server returns the requested content Actual: The server returns the error Request is missing required `Host` header

Contributor guide

Tech stack
scala
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ScalaHTTP/1.1Akka HTTP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is about the HTTP request parser in Akka HTTP. The relevant source file is likely the request parsing code, such as `akka http core/src/main/scala/akka/http/impl/engine/parsing/HttpRequestParser.scala`. The fix involves modifying the parsing logic to accept an empty Host header value as per RFC 7230. The maintainers have not provided specific guidance in the issue comments. A newcomer should look at how the Host header is currently validated and ensure that an empty value is allowed instead of treating it as missing.