akka/akka-http

Specs2 Test Interface 'afterAll' not calling super method

Open

#1,450 opened on Oct 3, 2017

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Scala (598 forks)batch import
1 - triagedhelp wantedt:testing

Repository metrics

Stars
 (1,311 stars)
PR merge metrics
 (Avg merge 1d 10h) (2 merged PRs in 30d)

Description

https://github.com/akka/akka-http/blob/master/akka-http-testkit/src/main/scala/akka/http/scaladsl/testkit/TestFrameworkInterface.scala

The ScalaTest impl calls their afterAll, but the Specs2 one does not. This actually causes some pain in testing frameworks as we have to override the afterall and call the 'cleanup' directly.

Contributor guide

Research direction
Examine the Specs2 implementation file and compare with the ScalaTest version to identify where the super.afterAll call is missing.
Tech stack
scala
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Scalasbt
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75