akka/akka-http

Http: Make PredefinedFromEntityUnmarshallers bail-out after certain nr of bytes read-in

Open

#143 opened on Sep 8, 2016

View on GitHub
 (9 comments) (0 reactions) (0 assignees)Scala (598 forks)batch import
1 - triagedbughelp wantedt:marshalling

Repository metrics

Stars
 (1,311 stars)
PR merge metrics
 (Avg merge 1d 10h) (2 merged PRs in 30d)

Description

Issue by ktoso Thursday Dec 03, 2015 at 14:52 GMT Originally opened as https://github.com/akka/akka/issues/19080

As discussed in https://github.com/akka/akka/pull/19042#discussion_r46096801

We are currently limiting the total number of bytes in a request body, however the same does not happen for individual Marshallers. This is most noticeably not nice when using FormFields or streaming Source[Element]. We should provide a config value to be provided implicitly after how many bytes such marshaller should bail out – we'd have "per element" limit and "per entire request" limit then.

Contributor guide

Research direction
Identify the marshalling pipeline in Akka HTTP and locate where per element byte limits should be enforced. Look for existing configuration for total request body limits and replicate similar logic for individual marshallers, particularly for FormFields and streaming sources.
Tech stack
scala
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ScalaAkka
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40