akka/akka-http

HttpHeader.parse can only use default settings

Open

#1,265 opened on Jul 4, 2017

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Scala (598 forks)batch import
1 - triagedhelp wantedplay-akka-http-integrationt:core

Repository metrics

Stars
 (1,311 stars)
PR merge metrics
 (Avg merge 1d 10h) (2 merged PRs in 30d)

Description

Currently when using HttpHeader.parse manually there is no way to override the Settings, since they are private.

Actually Play is using it to encode response headers: https://github.com/playframework/playframework/blob/master/framework/src/play-akka-http-server/src/main/scala/play/core/server/akkahttp/AkkaModelConversion.scala#L276

It would be great if there was a public way on overriding them, even a typesafe Config object would be fine.

Contributor guide

Research direction
Examine the current HttpHeader.parse implementation to identify how settings are used and propose a way to pass custom settings, such as an additional parameter or a Config object.
Tech stack
scala
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Scala
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75