akka/akka-core

StubbedActorContext.scheduleOnce returns canceled Cancellable

Open

#28,596 opened on Feb 11, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Scala (3,547 forks)batch import
1 - triagedhelp wantedt:testingt:typed

Repository metrics

Stars
 (13,277 stars)
PR merge metrics
 (Avg merge 8d 19h) (10 merged PRs in 30d)

Description

The current implementation of StubbedActorContext.scheduleOnce always returns an already canceled Cancellable. This makes it impossible to test any logic that relies on the state of the scheduled event (keeping an existing one vs. creating a new one based on its state).

Since one would expect to succeed in scheduling a new event with StubbedActorContext.scheduleOnce, shouldn't the stub returned be one that is uncancelle and transitions to cancelled if .cancel()` is called? If that change in behavior is acceptable, I'd gladly provide a PR for it.

Contributor guide

Research direction
Modify StubbedActorContext.scheduleOnce to return a Cancellable that is not initially canceled, and implement cancel() to transition it to canceled. Then verify existing tests pass and add a test for the new behavior.
Tech stack
scala
Domain
backenddistributed systems
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ScalaAkka
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60